]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
HID: logitech-hidpp: check name retrieval return code
authorPeter Wu <peter@lekensteyn.nl>
Thu, 11 Dec 2014 12:51:18 +0000 (13:51 +0100)
committerJiri Kosina <jkosina@suse.cz>
Thu, 11 Dec 2014 22:10:00 +0000 (23:10 +0100)
commit1430ee73b566a30bc210501d1e0e99c519707f1e
treeb16d64b16d3f19f4675bc9787719795d1601d96c
parent02cc097e62d51bf6e5cb4209ca90d9bf68e358b5
HID: logitech-hidpp: check name retrieval return code

hidpp_devicenametype_get_device_name() may return a negative value on
protocol errors (for example, when the device is powered off).
Explicitly check this condition to avoid a long-running loop.

(0 cannot be returned as __name_length - index > 0, but check for it
anyway as it would otherwise result in an infinite loop.)

Signed-off-by: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-logitech-hidpp.c