]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
ixgbe: do not call check_link for ethtool in ixgbe_get_settings()
authorEmil Tantilov <emil.s.tantilov@intel.com>
Thu, 3 Dec 2015 23:20:06 +0000 (15:20 -0800)
committerTim Gardner <tim.gardner@canonical.com>
Mon, 29 Feb 2016 15:56:58 +0000 (08:56 -0700)
commit14a897b8839ee6dde403eb8dbb8476959a402c47
tree3aa3dbec58044c7509b6a723e9667509cf3bae5b
parentdf7e70e30d6302659363072efa072cb2a3b87af7
ixgbe: do not call check_link for ethtool in ixgbe_get_settings()

BugLink: http://bugs.launchpad.net/bugs/1536473
In ixgbe_get_settings() the link status and speed of the interface
are determined based on a read from the LINKS register via the call
to mac.ops.check.link(). This can cause issues where external drivers
may end up with unknown speed when calling ethtool_get_setings().

Instead of calling the mac.ops.check_link() we can report the speed
from the adapter structure which is populated by the driver.

Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
(cherry picked from commit 0e4d422f5f7249324ac8d1b8e12772e530787a66)
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c