]> git.proxmox.com Git - mirror_qemu.git/commit
pseries: Clean up error handling in spapr_vga_init()
authorDavid Gibson <david@gibson.dropbear.id.au>
Wed, 20 Jan 2016 01:58:39 +0000 (12:58 +1100)
committerDavid Gibson <david@gibson.dropbear.id.au>
Sat, 30 Jan 2016 12:37:37 +0000 (23:37 +1100)
commit14c6a8949799573570b62cf50c519a3b34a2499b
treea411abeae596f86474f3914f314bfadae7bb1dbd
parent7c150d6f04f23dbcb4402bd5e16a8c86757a727a
pseries: Clean up error handling in spapr_vga_init()

Use error_setg() to return an error rather than an explicit exit().
Previously it was an exit(0) instead of a non-zero exit code, which was
simply a bug.  Also improve the error message.

While we're at it change the type of spapr_vga_init() to bool since that's
how we're using it anyway.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
hw/ppc/spapr.c