]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
drm/virtio: do NOT reuse resource ids
authorGerd Hoffmann <kraxel@redhat.com>
Fri, 8 Feb 2019 14:04:09 +0000 (15:04 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 14 May 2019 18:55:24 +0000 (20:55 +0200)
commit14db60440dcabc7698827869c771160bd7e00036
treeb666aed7c433630dcd09c6627270ffdd7bb1fd40
parent860d58382624cf9a4dec4e15a909ba15875e2628
drm/virtio: do NOT reuse resource ids

BugLink: https://bugs.launchpad.net/bugs/1828415
commit 16065fcdd19ddb9e093192914ac863884f308766 upstream.

Bisected guest kernel changes crashing qemu.  Landed at
"6c1cd97bda drm/virtio: fix resource id handling".  Looked again, and
noticed we where not only leaking *some* ids, but *all* ids.  The old
code never ever called virtio_gpu_resource_id_put().

So, commit 6c1cd97bda effectively makes the linux kernel starting
re-using IDs after releasing them, and apparently virglrenderer can't
deal with that.  Oops.

This patch puts a temporary stopgap into place for the 5.0 release.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190208140409.15280-1-kraxel@redhat.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/gpu/drm/virtio/virtgpu_object.c