]> git.proxmox.com Git - ovs.git/commit
ovn-nbctl: Initialize arguments to avoid compilation warnings.
authorIan Stokes <ian.stokes@intel.com>
Wed, 25 Jul 2018 14:00:43 +0000 (15:00 +0100)
committerBen Pfaff <blp@ovn.org>
Tue, 31 Jul 2018 19:52:17 +0000 (12:52 -0700)
commit14faed569586a7458134bd8140cb19833568c3b8
tree8887b0873f3be4a034a98ce5060c5e356e6e61dc
parent82b261b9efdb7af4c2146178db10e901a9580f30
ovn-nbctl: Initialize arguments to avoid compilation warnings.

Output arguments for parse_priority() and dhcp_options_get() may not be
initialized when either function returns an error.

This causes compilation warnings for GCC 6.3.x regarding use of
uninitialized variable use and null-pointer-arithmetic.

Fix this by initializing priority_p* value to 0 for priority_parse()
when an error occurs during parsing.

For dhcp_options_get() set *dhcp_opts_p = dhcp_opts regardless as
dhcp_opts will be equal to NULL when an error occurs within the function
anyhow.

Cc: Jakub Sitnicki <jkbs@redhat.com>
Fixes: 3844c85de979 ("ovn-nbctl: Don't die in dhcp_options_get()."
Fixes: bc8223df3b01 ("ovn-nbctl: Don't die in parse_priority().")
Signed-off-by: Ian Stokes <ian.stokes@intel.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
Acked-by: Jakub Sitnicki <jkbs@redhat.com>
ovn/utilities/ovn-nbctl.c