]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
drm/i915/execlists: Drop request-before-CS assertion
authorChris Wilson <chris@chris-wilson.co.uk>
Wed, 22 Apr 2020 14:17:49 +0000 (15:17 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 22 Apr 2020 16:17:50 +0000 (17:17 +0100)
commit15501287b1c1827d21cce14a868467a80060eccd
tree675eb1d6d28d81c22af9d937187d6028e31b98ff
parentcb593e5d2b6d3ad489669914d9fd1c64c7a4a6af
drm/i915/execlists: Drop request-before-CS assertion

When we migrated to execlists, one of the conditions we wanted to test
for was whether the breadcrumb seqno was being written before the
breadcumb interrupt was delivered. This was following on from issues
observed on previous generations which were not so strongly ordered. With
the removal of the missed interrupt detection, we have not reliable
means of detecting the out-of-order seqno/interrupt but instead tried to
assert that the relationship between the CS event interrupt and the
breadwrite should be strongly ordered. However, Icelake proves it is
possible for the HW implementation to forget about minor little details
such as write ordering and so the order between *processing* the CS
event and the breadcrumb is unreliable.

Remove the unreliable assertion, but leave a debug telltale in case we
have reason to suspect.

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1658
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200422141749.28709-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gt/intel_lrc.c