]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
tracing/histogram: Fix a potential memory leak for kstrdup()
authorXiaoke Wang <xkernel.wang@foxmail.com>
Tue, 25 Jan 2022 04:07:15 +0000 (12:07 +0800)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 29 Mar 2022 07:13:37 +0000 (09:13 +0200)
commit15878b4969eeee98d5b67614b778248952e7eb7d
tree82679507fd9bfa9d7c5665d4d720b649b8c6368b
parentd06e580c16314409315d4a05b26ecaba73a9b51e
tracing/histogram: Fix a potential memory leak for kstrdup()

BugLink: https://bugs.launchpad.net/bugs/1962345
commit e629e7b525a179e29d53463d992bdee759c950fb upstream.

kfree() is missing on an error path to free the memory allocated by
kstrdup():

  p = param = kstrdup(data->params[i], GFP_KERNEL);

So it is better to free it via kfree(p).

Link: https://lkml.kernel.org/r/tencent_C52895FD37802832A3E5B272D05008866F0A@qq.com
Cc: stable@vger.kernel.org
Fixes: d380dcde9a07c ("tracing: Fix now invalid var_ref_vals assumption in trace action")
Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
kernel/trace/trace_events_hist.c