]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
i40e: fix mac filter delete when setting mac address
authorStefan Assmann <sassmann@kpanic.de>
Tue, 4 Dec 2018 14:18:52 +0000 (15:18 +0100)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 12 Dec 2018 22:54:48 +0000 (14:54 -0800)
commit158daed16efb1170694e420ae06ba8ba954d82e5
tree8734d86c24d63473fc02c442aecd334bba2e81ef
parentee28b30cbbe0b490f52ba222c9d392b99581545e
i40e: fix mac filter delete when setting mac address

A previous commit moved the ether_addr_copy() in i40e_set_mac() before
the mac filter del/add to avoid a race. However it wasn't taken into
account that this alters the mac address being handed to
i40e_del_mac_filter().

Also changed i40e_add_mac_filter() to operate on netdev->dev_addr,
hopefully that makes the code easier to read.

Fixes: 458867b2ca0c ("i40e: don't remove netdev->dev_addr when syncing uc list")
Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Acked-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40e/i40e_main.c