]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
KVM: x86: do not report preemption if the steal time cache is stale
authorPaolo Bonzini <pbonzini@redhat.com>
Thu, 4 Aug 2022 13:28:32 +0000 (15:28 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 17 Oct 2022 09:55:46 +0000 (11:55 +0200)
commit15b5a9dbc9f457821415903257475b79ea46a597
tree6bccc942aeb239e74fd8b132aa0bddc26a2e6f58
parent56c8d323fb77f299aefb93ed063b6f5b70bee147
KVM: x86: do not report preemption if the steal time cache is stale

BugLink: https://bugs.launchpad.net/bugs/1990162
commit c3c28d24d910a746b02f496d190e0e8c6560224b upstream.

Commit 7e2175ebd695 ("KVM: x86: Fix recording of guest steal time
/ preempted status", 2021-11-11) open coded the previous call to
kvm_map_gfn, but in doing so it dropped the comparison between the cached
guest physical address and the one in the MSR.  This cause an incorrect
cache hit if the guest modifies the steal time address while the memslots
remain the same.  This can happen with kexec, in which case the preempted
bit is written at the address used by the old kernel instead of
the old one.

Cc: David Woodhouse <dwmw@amazon.co.uk>
Cc: stable@vger.kernel.org
Fixes: 7e2175ebd695 ("KVM: x86: Fix recording of guest steal time / preempted status")
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
arch/x86/kvm/x86.c