]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
gpio: Remove dev_err() usage after platform_get_irq()
authorStephen Boyd <swboyd@chromium.org>
Tue, 30 Jul 2019 18:15:15 +0000 (11:15 -0700)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 5 Aug 2019 11:25:34 +0000 (13:25 +0200)
commit15bddb7d787aebc837912cecf107b7eaccf03913
tree09f3fbce435a528a825fedc5de3ae0adaca63972
parent74d2d0e68701bcd53d2cf771dd3b3cb9f84bed5c
gpio: Remove dev_err() usage after platform_get_irq()

We don't need dev_err() messages when platform_get_irq() fails now that
platform_get_irq() prints an error message itself when something goes
wrong. Let's remove these prints with a simple semantic patch.

// <smpl>
@@
expression ret;
struct platform_device *E;
@@

ret =
(
platform_get_irq(E, ...)
|
platform_get_irq_byname(E, ...)
);

if ( \( ret < 0 \| ret <= 0 \) )
{
(
-if (ret != -EPROBE_DEFER)
-{ ...
-dev_err(...);
-... }
|
...
-dev_err(...);
)
...
}
// </smpl>

While we're here, remove braces on if statements that only have one
statement (manually).

Cc: linux-gpio@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/20190730181557.90391-16-swboyd@chromium.org
Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-brcmstb.c
drivers/gpio/gpio-eic-sprd.c
drivers/gpio/gpio-grgpio.c
drivers/gpio/gpio-max77620.c
drivers/gpio/gpio-pmic-eic-sprd.c
drivers/gpio/gpio-sprd.c
drivers/gpio/gpio-tb10x.c
drivers/gpio/gpio-tegra.c
drivers/gpio/gpio-zx.c
drivers/gpio/gpio-zynq.c