]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
perf annotate: Fix segmentation fault
authorIngo Molnar <mingo@elte.hu>
Tue, 18 Aug 2009 11:52:28 +0000 (13:52 +0200)
committerIngo Molnar <mingo@elte.hu>
Tue, 18 Aug 2009 12:00:52 +0000 (14:00 +0200)
commit15f3fa4e7f608c5ce19187b3b4a953222fdfa751
tree97ef1f8e7beb151759a664ddda1a4d1c5cfdc84d
parentf738eb1b63edf664da1b4ac76895d988749b2f07
perf annotate: Fix segmentation fault

Linus reported this perf annotate segfault:

        [torvalds@nehalem git]$ perf annotate unmap_vmas
        Segmentation fault

        #0  map__clone (self=<value optimized out>) at builtin-annotate.c:236
        #1  thread__fork (self=<value optimized out>) at builtin-annotate.c:372

The bug here was that builtin-annotate.c was a copy of
builtin-report.c and a threading related fix to builtin-report.c
didnt get propagated to builtin-annotate.c ...

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
tools/perf/builtin-annotate.c