]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
pinctrl: rockchip: add pinmux_ops.gpio_set_direction callback
authorQuentin Schulz <quentin.schulz@theobroma-systems.com>
Fri, 30 Sep 2022 13:20:32 +0000 (15:20 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Thu, 24 Nov 2022 13:24:00 +0000 (14:24 +0100)
commit162742eed25bf7780dcef78cf9c619383493d82f
tree269a154c012700e4b79c7dbb05afa463dc1e85ad
parenta6a7430f90e770943de02c4f61c3931d53bb418e
pinctrl: rockchip: add pinmux_ops.gpio_set_direction callback

BugLink: https://bugs.launchpad.net/bugs/1996825
commit 4635c0e2a7f7f3568cbfccae70121f9835efa62c upstream.

Before the split of gpio and pinctrl sections in their own driver,
rockchip_set_mux was called in pinmux_ops.gpio_set_direction for
configuring a pin in its GPIO function.

This is essential for cases where pinctrl is "bypassed" by gpio
consumers otherwise the GPIO function is not configured for the pin and
it does not work. Such was the case for the sysfs/libgpiod userspace
GPIO handling.

Let's re-implement the pinmux_ops.gpio_set_direction callback so that
the gpio subsystem can request from the pinctrl driver to put the pin in
its GPIO function.

Fixes: 9ce9a02039de ("pinctrl/rockchip: drop the gpio related codes")
Cc: stable@vger.kernel.org
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Link: https://lore.kernel.org/r/20220930132033.4003377-2-foss+kernel@0leil.net
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/pinctrl/pinctrl-rockchip.c