]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
tick/rcu: Fix bogus ratelimit condition
authorWen Yang <wenyang.linux@foxmail.com>
Thu, 4 May 2023 16:12:53 +0000 (00:12 +0800)
committerRoxana Nicolescu <roxana.nicolescu@canonical.com>
Mon, 2 Oct 2023 15:19:31 +0000 (17:19 +0200)
commit162d7273d6ac0344d998ea2ed3127fd4dd26c572
tree44ff6bd74ae50776cbb5a6e6128ff9d5fa59f8d4
parent7b891959d9b32b6b4164d5a2d31f9b48817b80e2
tick/rcu: Fix bogus ratelimit condition

BugLink: https://bugs.launchpad.net/bugs/2034469
[ Upstream commit a7e282c77785c7eabf98836431b1f029481085ad ]

The ratelimit logic in report_idle_softirq() is broken because the
exit condition is always true:

static int ratelimit;

if (ratelimit < 10)
return false;  ---> always returns here

ratelimit++;           ---> no chance to run

Make it check for >= 10 instead.

Fixes: 0345691b24c0 ("tick/rcu: Stop allowing RCU_SOFTIRQ in idle")
Signed-off-by: Wen Yang <wenyang.linux@foxmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/tencent_5AAA3EEAB42095C9B7740BE62FBF9A67E007@qq.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
kernel/time/tick-sched.c