]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
igb: Fix constant media auto sense switching when no cable is connected
authorManfred Rudigier <manfred.rudigier@omicronenergy.com>
Thu, 15 Aug 2019 20:55:20 +0000 (13:55 -0700)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 26 Nov 2019 12:16:15 +0000 (13:16 +0100)
commit164a037d6a29c1b08b40aa793892e08891918d82
treeb7a6ff6ba53c53a88b9ece849a3e6df7e473a836
parent69ca28869a1f24aa914d905fddfafba6738e5e6e
igb: Fix constant media auto sense switching when no cable is connected

BugLink: https://bugs.launchpad.net/bugs/1853519
[ Upstream commit 8d5cfd7f76a2414e23c74bb8858af7540365d985 ]

At least on the i350 there is an annoying behavior that is maybe also
present on 82580 devices, but was probably not noticed yet as MAS is not
widely used.

If no cable is connected on both fiber/copper ports the media auto sense
code will constantly swap between them as part of the watchdog task and
produce many unnecessary kernel log messages.

The swap code responsible for this behavior (switching to fiber) should
not be executed if the current media type is copper and there is no signal
detected on the fiber port. In this case we can safely wait until the
AUTOSENSE_EN bit is cleared.

Signed-off-by: Manfred Rudigier <manfred.rudigier@omicronenergy.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/net/ethernet/intel/igb/igb_main.c