]> git.proxmox.com Git - mirror_qemu.git/commit
migration/multifd: Stop checking p->quit in multifd_send_thread
authorFabiano Rosas <farosas@suse.de>
Thu, 12 Oct 2023 14:06:47 +0000 (11:06 -0300)
committerJuan Quintela <quintela@redhat.com>
Fri, 20 Oct 2023 06:51:41 +0000 (08:51 +0200)
commit175e63c9829f9887c04bed8e0c4906e1166c9a87
tree249f909d2bc1e1abd2384f63617a7bd1e5a217aa
parentd9cda21303a2b92cf3be48b75d4201896aa06857
migration/multifd: Stop checking p->quit in multifd_send_thread

We don't need to check p->quit in the multifd_send_thread() because it
is shadowed by the 'exiting' flag. Ever since that flag was added
p->quit became obsolete as a way to stop the thread.

Since p->quit is set at multifd_send_terminate_threads() under the
p->mutex lock, the thread will only see it once it loops, so 'exiting'
will always be seen first.

Note that setting p->quit at multifd_send_terminate_threads() still
makes sense because we need a way to inform multifd_send_pages() that
the channel has stopped.

Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20231012140651.13122-3-farosas@suse.de>
migration/multifd.c