]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
mmc: sdhci: Do not disable interrupts while waiting for clock
authorAdrian Hunter <adrian.hunter@intel.com>
Mon, 20 Mar 2017 17:50:29 +0000 (19:50 +0200)
committerTim Gardner <tim.gardner@canonical.com>
Thu, 30 Mar 2017 12:35:45 +0000 (06:35 -0600)
commit17982c5407a7fcf22ff3fa76601ab1805a9a9116
tree87f3ca584587c54732ace3dcf197b6ab4f96158a
parent5f8925ab7faeef3f44c81bca1b77925243fa0fa6
mmc: sdhci: Do not disable interrupts while waiting for clock

BugLink: http://bugs.launchpad.net/bugs/1677589
commit e2ebfb2142acefecc2496e71360f50d25726040b upstream.

Disabling interrupts for even a millisecond can cause problems for some
devices. That can happen when sdhci changes clock frequency because it
waits for the clock to become stable under a spin lock.

The spin lock is not necessary here. Anything that is racing with changes
to the I/O state is already broken. The mmc core already provides
synchronization via "claiming" the host.

Although the spin lock probably should be removed from the code paths that
lead to this point, such a patch would touch too much code to be suitable
for stable trees. Consequently, for this patch, just drop the spin lock
while waiting.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Tested-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
drivers/mmc/host/sdhci.c