]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
pktcdvd: Fix a recently introduced NULL pointer dereference
authorBart Van Assche <bart.vanassche@wdc.com>
Tue, 2 Jan 2018 19:39:48 +0000 (11:39 -0800)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 22 Feb 2018 14:21:54 +0000 (08:21 -0600)
commit17dc1177a631a293a11f6c672db0be1e3939d2a3
tree46746ce86beefaf49bb12fd258ec6f1c5d17dddd
parentacef9622cc7ecfd7f466ee80fe17c1c093c717fb
pktcdvd: Fix a recently introduced NULL pointer dereference

BugLink: http://bugs.launchpad.net/bugs/1751064
commit 882d4171a8950646413b1a3cbe0e4a6a612fe82e upstream.

Call bdev_get_queue(bdev) after bdev->bd_disk has been initialized
instead of just before that pointer has been initialized. This patch
avoids that the following command

pktsetup 1 /dev/sr0

triggers the following kernel crash:

BUG: unable to handle kernel NULL pointer dereference at 0000000000000548
IP: pkt_setup_dev+0x2db/0x670 [pktcdvd]
CPU: 2 PID: 724 Comm: pktsetup Not tainted 4.15.0-rc4-dbg+ #1
Call Trace:
 pkt_ctl_ioctl+0xce/0x1c0 [pktcdvd]
 do_vfs_ioctl+0x8e/0x670
 SyS_ioctl+0x3c/0x70
 entry_SYSCALL_64_fastpath+0x23/0x9a

Reported-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Fixes: commit ca18d6f769d2 ("block: Make most scsi_req_init() calls implicit")
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Tested-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Cc: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
drivers/block/pktcdvd.c