]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
s390/cio: fix accidental interrupt enabling during resume
authorSebastian Ott <sebott@linux.vnet.ibm.com>
Wed, 28 Sep 2016 11:36:19 +0000 (13:36 +0200)
committerLuis Henriques <luis.henriques@canonical.com>
Tue, 8 Nov 2016 16:46:27 +0000 (16:46 +0000)
commit1856e9afefef6566f794d1864732d32c8c1a1787
tree1b34eb818d74cde77f218120ed5b2434baa934fe
parent822681992fb556c1acdbe499878f12b9888ec1a9
s390/cio: fix accidental interrupt enabling during resume

BugLink: http://bugs.launchpad.net/bugs/1638267
commit d53c51f26145657aa7c55fa396f93677e613548d upstream.

Since commit 9f3d6d7 chsc_get_channel_measurement_chars is called with
interrupts disabled during resume from hibernate. Since this function
used spin_unlock_irq, interrupts have been enabled accidentally. Fix
this by using the irqsave variant.

Since we can't guarantee the IRQ-enablement state for all (future/
external) callers, change the locking in related functions to prevent
similar bugs in the future.

Fixes: 9f3d6d7 ("s390/cio: update measurement characteristics")
Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
Reviewed-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
drivers/s390/cio/chsc.c