]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: Fix skb->csum update in inet_proto_csum_replace16().
authorPraveen Chaudhary <praveen5582@gmail.com>
Thu, 23 Jan 2020 20:33:28 +0000 (12:33 -0800)
committerPablo Neira Ayuso <pablo@netfilter.org>
Fri, 24 Jan 2020 19:54:30 +0000 (20:54 +0100)
commit189c9b1e94539b11c80636bc13e9cf47529e7bba
treef5d91182faba28ae46bb45878575b841f9bbdf20
parenteb014de4fd418de1a277913cba244e47274fe392
net: Fix skb->csum update in inet_proto_csum_replace16().

skb->csum is updated incorrectly, when manipulation for
NF_NAT_MANIP_SRC\DST is done on IPV6 packet.

Fix:
There is no need to update skb->csum in inet_proto_csum_replace16(),
because update in two fields a.) IPv6 src/dst address and b.) L4 header
checksum cancels each other for skb->csum calculation. Whereas
inet_proto_csum_replace4 function needs to update skb->csum, because
update in 3 fields a.) IPv4 src/dst address, b.) IPv4 Header checksum
and c.) L4 header checksum results in same diff as L4 Header checksum
for skb->csum calculation.

[ pablo@netfilter.org: a few comestic documentation edits ]
Signed-off-by: Praveen Chaudhary <pchaudhary@linkedin.com>
Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
Signed-off-by: Andy Stracner <astracner@linkedin.com>
Reviewed-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/core/utils.c