]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
dmaengine: qcom_hidma: initialize tx flags in hidma_prep_dma_*
authorShunyong Yang <shunyong.yang@hxt-semitech.com>
Mon, 7 Jan 2019 01:32:14 +0000 (09:32 +0800)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commit18ab5d8bcc0de71205e30a054e479d13e831b4e7
treef3022bc44e64621162f1e9bdafcdfbe57766ade3
parent3d542627b7acb58359e76ac56a9d7be25c6d2c2a
dmaengine: qcom_hidma: initialize tx flags in hidma_prep_dma_*

BugLink: https://bugs.launchpad.net/bugs/1838116
[ Upstream commit 875aac8a46424e5b73a9ff7f40b83311b609e407 ]

In async_tx_test_ack(), it uses flags in struct dma_async_tx_descriptor
to check the ACK status. As hidma reuses the descriptor in a free list
when hidma_prep_dma_*(memcpy/memset) is called, the flag will keep ACKed
if the descriptor has been used before. This will cause a BUG_ON in
async_tx_quiesce().

  kernel BUG at crypto/async_tx/async_tx.c:282!
  Internal error: Oops - BUG: 0 1 SMP
  ...
  task: ffff8017dd3ec000 task.stack: ffff8017dd3e8000
  PC is at async_tx_quiesce+0x54/0x78 [async_tx]
  LR is at async_trigger_callback+0x98/0x110 [async_tx]

This patch initializes flags in dma_async_tx_descriptor by the flags
passed from the caller when hidma_prep_dma_*(memcpy/memset) is called.

Cc: Joey Zheng <yu.zheng@hxt-semitech.com>
Reviewed-by: Sinan Kaya <okaya@kernel.org>
Signed-off-by: Shunyong Yang <shunyong.yang@hxt-semitech.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/dma/qcom/hidma.c