]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
drm/bridge: analogix_dp: return error if transfer none byte
authorJianqun Xu <jay.xu@rock-chips.com>
Wed, 16 Nov 2016 00:13:39 +0000 (08:13 +0800)
committerArchit Taneja <architt@codeaurora.org>
Wed, 16 Nov 2016 05:46:13 +0000 (11:16 +0530)
commit19423ba7109a94dfb3beda88f9dcced54e4831d8
treedc56549cebe5235898a1e781bd209e8e96f54bd7
parentb9876d5061a068ba647c8b9923aff8c975bb73a3
drm/bridge: analogix_dp: return error if transfer none byte

Reference from drm_dp_aux description (about transfer):
Upon success, the implementation should return the number of payload bytes
that were transferred, or a negative error-code on failure. Helpers
propagate errors from the .transfer() function, with the exception of
the -EBUSY error, which causes a transaction to be retried. On a short,
helpers will return -EPROTO to make it simpler to check for failure.

The analogix_dp_transfer will return num_transferred, but if there is none
byte been transferred, the return value will be 0, which means success, we
should return error-code if transfer none byte.

for (retry = 0; retry < 32; retry++) {
err = aux->transfer(aux, &msg);
if (err < 0) {
if (err == -EBUSY)
continue;

goto unlock;
}
}

Cc: zain wang <wzz@rock-chips.com>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
Signed-off-by: Archit Taneja <architt@codeaurora.org>
Link: http://patchwork.freedesktop.org/patch/msgid/1479255219-7243-1-git-send-email-jay.xu@rock-chips.com
drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c