]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
media: Revert "[media] tvp5150: fix pad format frame height"
authorJavier Martinez Canillas <javierm@redhat.com>
Sun, 10 Jun 2018 20:43:02 +0000 (16:43 -0400)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:45:34 +0000 (19:45 -0600)
commit198b51d11930a67bb3d3b66abaf3155da3a7609b
tree3fd5609be1ab4651c4d8cd3c0d9f52de7b547aa5
parent93ff818bb9e8e91aa2aa6a9d4e96c599b57b26b5
media: Revert "[media] tvp5150: fix pad format frame height"

BugLink: https://bugs.launchpad.net/bugs/1835972
commit 1831af092308aa5a59ae61e47494e441c8be6b93 upstream.

This reverts commit 0866df8dffd514185bfab0d205db76e4c02cf1e4.

The v4l uAPI documentation [0] makes clear that in the case of interlaced
video (i.e: field is V4L2_FIELD_ALTERNATE) the height refers to the number
of lines in the field and not the number of lines in the full frame (which
is twice the field height for interlaced formats).

So the original height calculation was correct, and it shouldn't had been
changed by the mentioned commit.

[0]:https://linuxtv.org/downloads/v4l-dvb-apis/uapi/v4l/subdev-formats.html

Fixes: 0866df8dffd5 ("[media] tvp5150: fix pad format frame height")
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Cc: <stable@vger.kernel.org> # for v4.12 and up
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/media/i2c/tvp5150.c