]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
ACPI/IORT: Check node revision for PMCG resources
authorRobin Murphy <robin.murphy@arm.com>
Thu, 3 Feb 2022 19:31:24 +0000 (19:31 +0000)
committerStefan Bader <stefan.bader@canonical.com>
Thu, 14 Apr 2022 09:32:02 +0000 (11:32 +0200)
commit19f1f89ccfbcd77b0e341fe11f2908876b6dea0d
treef07daf4ceca3e91c9359f6ae9516d2d85524866a
parent156b710cfe8d533d9965671963ea77a173ad387c
ACPI/IORT: Check node revision for PMCG resources

BugLink: https://bugs.launchpad.net/bugs/1966118
commit da5fb9e1ad3fbf632dce735f1bdad257ca528499 upstream.

The original version of the IORT PMCG definition had an oversight
wherein there was no way to describe the second register page for an
implementation using the recommended RELOC_CTRS feature. Although the
spec was fixed, and the final patches merged to ACPICA and Linux written
against the new version, it seems that some old firmware based on the
original revision has survived and turned up in the wild.

Add a check for the original PMCG definition, and avoid filling in the
second memory resource with nonsense if so. Otherwise it is likely that
something horrible will happen when the PMCG driver attempts to probe.

Reported-by: Michael Petlan <mpetlan@redhat.com>
Fixes: 24e516049360 ("ACPI/IORT: Add support for PMCG")
Cc: <stable@vger.kernel.org> # 5.2.x
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Link: https://lore.kernel.org/r/75628ae41c257fb73588f7bf1c4459160e04be2b.1643916258.git.robin.murphy@arm.com
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/acpi/arm64/iort.c