]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
svcrdma: Ignore source port when computing DRC hash
authorChuck Lever <chuck.lever@oracle.com>
Tue, 11 Jun 2019 15:01:16 +0000 (11:01 -0400)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commit1a08665e59ea054b6f8735600edff5021388f9cc
tree664a41ebd1450ec3300bc1f0e842596915c7f6d4
parent6708866ee6b087f6cca0d8ab915824d59357b895
svcrdma: Ignore source port when computing DRC hash

BugLink: https://bugs.launchpad.net/bugs/1838824
commit 1e091c3bbf51d34d5d96337a59ce5ab2ac3ba2cc upstream.

The DRC appears to be effectively empty after an RPC/RDMA transport
reconnect. The problem is that each connection uses a different
source port, which defeats the DRC hash.

Clients always have to disconnect before they send retransmissions
to reset the connection's credit accounting, thus every retransmit
on NFS/RDMA will miss the DRC.

An NFS/RDMA client's IP source port is meaningless for RDMA
transports. The transport layer typically sets the source port value
on the connection to a random ephemeral port. The server already
ignores it for the "secure port" check. See commit 16e4d93f6de7
("NFSD: Ignore client's source port on RDMA transports").

The Linux NFS server's DRC resolves XID collisions from the same
source IP address by using the checksum of the first 200 bytes of
the RPC call header.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Cc: stable@vger.kernel.org # v4.14+
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
net/sunrpc/xprtrdma/svc_rdma_transport.c