]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
rtw88: Disable PCIe ASPM while doing NAPI poll on 8821CE
authorKai-Heng Feng <kai.heng.feng@canonical.com>
Wed, 22 Dec 2021 06:37:57 +0000 (14:37 +0800)
committerAndrea Righi <andrea.righi@canonical.com>
Tue, 4 Jan 2022 09:15:18 +0000 (10:15 +0100)
commit1a0cba8dfcaa4b8e4d3611ee91805109575d696f
tree871c065febbe3ff6bf389bc1fc760970d72bc5b4
parent1649d1cb37d40ea2350649ef4378edd1f4f61bb8
rtw88: Disable PCIe ASPM while doing NAPI poll on 8821CE

BugLink: https://bugs.launchpad.net/bugs/1927808
Many Intel based platforms face system random freeze after commit
9e2fd29864c5 ("rtw88: add napi support").

The commit itself shouldn't be the culprit. My guess is that the 8821CE
only leaves ASPM L1 for a short period when IRQ is raised. Since IRQ is
masked during NAPI polling, the PCIe link stays at L1 and makes RX DMA
extremely slow. Eventually the RX ring becomes messed up:
[ 1133.194697] rtw_8821ce 0000:02:00.0: pci bus timeout, check dma status

Since the 8821CE hardware may fail to leave ASPM L1, manually do it in
the driver to resolve the issue.

Fixes: 9e2fd29864c5 ("rtw88: add napi support")
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215131
BugLink: https://bugs.launchpad.net/bugs/1927808
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Acked-by: Jian-Hong Pan <jhp@endlessos.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20211215114635.333767-1-kai.heng.feng@canonical.com
(backported from commit 24f5e38a13b5ae2b6105cda8bb47c19108e62a9a linux-next)
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
drivers/net/wireless/realtek/rtw88/pci.c
drivers/net/wireless/realtek/rtw88/pci.h