]> git.proxmox.com Git - mirror_qemu.git/commit
target/riscv: pmp: Ignore writes when RW=01 and MML=0
authorIvan Klokov <ivan.klokov@syntacore.com>
Wed, 20 Dec 2023 15:32:05 +0000 (18:32 +0300)
committerAlistair Francis <alistair.francis@wdc.com>
Wed, 10 Jan 2024 08:47:47 +0000 (18:47 +1000)
commit1a25e59c621f77cf21ad7dd9a86606170ff6e4b6
tree9d2e7a74b8ab7a4d99e219cedbb9a7d9f5e7fc79
parent2abf0da22cbe7152940a2a90e7a4b7ba70ef04e7
target/riscv: pmp: Ignore writes when RW=01 and MML=0

This patch changes behavior on writing RW=01 to pmpcfg with MML=0.
RWX filed is form of collective WARL with the combination of
pmpcfg.RW=01 remains reserved for future standard use.

According to definition of WARL writing the CSR has no other side
effect. But current implementation change architectural state and
change system behavior. After writing we will get unreadable-unwriteble
region regardless on the previous state.

On the other side WARL said that we should read legal value and nothing
says about what we should write. Current behavior change system state
regardless of whether we read this register or not.

Fixes: ac66f2f0 ("target/riscv: pmp: Ignore writes when RW=01")
Signed-off-by: Ivan Klokov <ivan.klokov@syntacore.com>
Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-ID: <20231220153205.11072-1-ivan.klokov@syntacore.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
target/riscv/pmp.c