]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ptp: ocp: Avoid operator precedence warning in ptp_ocp_summary_show()
authorNathan Chancellor <nathan@kernel.org>
Fri, 17 Sep 2021 04:52:05 +0000 (21:52 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 17 Sep 2021 17:32:08 +0000 (10:32 -0700)
commit1a575cde596c44aee04d2853d3d7067942a9612c
treea1d56173353244c978dd0dd6ce1d0292079884ef
parent5ef8a0291513c624b568acf15eee87e905736f2c
ptp: ocp: Avoid operator precedence warning in ptp_ocp_summary_show()

Clang warns twice:

drivers/ptp/ptp_ocp.c:2065:16: error: operator '?:' has lower precedence
than '&'; '&' will be evaluated first
[-Werror,-Wbitwise-conditional-parentheses]
                           on & map ? " ON" : "OFF", src);
                           ~~~~~~~~ ^
drivers/ptp/ptp_ocp.c:2065:16: note: place parentheses around the '&'
expression to silence this warning
                           on & map ? " ON" : "OFF", src);
                                    ^
                           (       )
drivers/ptp/ptp_ocp.c:2065:16: note: place parentheses around the '?:'
expression to evaluate it first
                           on & map ? " ON" : "OFF", src);
                                    ^

on and map are both booleans so this should be a logical AND, which
clears up the operator precedence issue.

Fixes: a62a56d04e63 ("ptp: ocp: Enable 4th timestamper / PPS generator")
Link: https://github.com/ClangBuiltLinux/linux/issues/1457
Suggested-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Link: https://lore.kernel.org/r/20210917045204.1385801-1-nathan@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/ptp/ptp_ocp.c