]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
can: flexcan: flexcan_remove(): disable wakeup completely
authorJoakim Zhang <qiangqing.zhang@nxp.com>
Tue, 20 Oct 2020 18:45:27 +0000 (02:45 +0800)
committerStefan Bader <stefan.bader@canonical.com>
Thu, 10 Dec 2020 11:06:14 +0000 (12:06 +0100)
commit1ab3bc9db7df550eccc4702fa23461e69113dc14
treed782c3b2b12533b6544846c26626ab20bd75060c
parentc86f554a87ca5a0739e4c862eafbe222e79831a8
can: flexcan: flexcan_remove(): disable wakeup completely

BugLink: https://bugs.launchpad.net/bugs/1905618
[ Upstream commit ab07ff1c92fa60f29438e655a1b4abab860ed0b6 ]

With below sequence, we can see wakeup default is enabled after re-load module,
if it was enabled before, so we need disable wakeup in flexcan_remove().

| # cat /sys/bus/platform/drivers/flexcan/5a8e0000.can/power/wakeup
| disabled
| # echo enabled > /sys/bus/platform/drivers/flexcan/5a8e0000.can/power/wakeup
| # cat /sys/bus/platform/drivers/flexcan/5a8e0000.can/power/wakeup
| enabled
| # rmmod flexcan
| # modprobe flexcan
| # cat /sys/bus/platform/drivers/flexcan/5a8e0000.can/power/wakeup
| enabled

Fixes: de3578c198c6 ("can: flexcan: add self wakeup support")
Fixes: 915f9666421c ("can: flexcan: add support for DT property 'wakeup-source'")
Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
Link: https://lore.kernel.org/r/20201020184527.8190-1-qiangqing.zhang@nxp.com
[mkl: streamlined commit message]
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/net/can/flexcan.c