]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
Revert "USB: core: hub.c: use usb_control_msg_send() in a few places"
authorOliver Neukum <oneukum@suse.com>
Wed, 23 Sep 2020 13:43:35 +0000 (15:43 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Sep 2020 14:33:58 +0000 (16:33 +0200)
commit1afe33a788c40287f3addb81788930f1fadc18a2
tree8c74cf2db78b75facbd0697e0690b41396e7fb0d
parent34d8f7a4627ca59ba915c7ea44fe9d9123875712
Revert "USB: core: hub.c: use usb_control_msg_send() in a few places"

This reverts commit d6a499249543356002a1efbb26254c7272e62f4c.
Control messages are needed in contexts when memory allocations
are restricted, such as handling device resets and runtime PM.

For this reason the control message API internally uses GFP_NOIO.
This is a band aid introduced because when we recognized the issue,
the call chains were highly convoluted. Continuing this trend
is not a good idea.

So I am shooting the whole kennel here.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Link: https://lore.kernel.org/r/20200923134348.23862-2-oneukum@suse.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/hub.c