]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
kdb: Cleanup math with KDB_CMD_HISTORY_COUNT
authorDouglas Anderson <dianders@chromium.org>
Thu, 7 May 2020 23:11:46 +0000 (16:11 -0700)
committerDaniel Thompson <daniel.thompson@linaro.org>
Tue, 2 Jun 2020 14:15:46 +0000 (15:15 +0100)
commit1b310030bb855b9b13d1c0a9feffdb54883b06ab
tree83c8710aa1c85c2cbb79ac3dfea06fe1a09fc2bc
parent195867ffea13b755dc727b47eaa5beb0ffa6e0ce
kdb: Cleanup math with KDB_CMD_HISTORY_COUNT

From code inspection the math in handle_ctrl_cmd() looks super sketchy
because it subjects -1 from cmdptr and then does a "%
KDB_CMD_HISTORY_COUNT".  It turns out that this code works because
"cmdptr" is unsigned and KDB_CMD_HISTORY_COUNT is a nice power of 2.
Let's make this a little less sketchy.

This patch should be a no-op.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20200507161125.1.I2cce9ac66e141230c3644b8174b6c15d4e769232@changeid
Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
kernel/debug/kdb/kdb_main.c