]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
ACPI / PCI: fix acpi_pci_irq_enable() memory leak
authorWenwen Wang <wenwen@cs.uga.edu>
Wed, 21 Aug 2019 03:44:19 +0000 (22:44 -0500)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 18 Oct 2019 08:25:58 +0000 (04:25 -0400)
commit1b5bd0f5c6436b93b420b729030e9590d9ddbf16
tree8535e59aa2e6545341e7e5ace5705575802f4bb4
parent2aa32cc5fd500ec3342238485ca93757edef248f
ACPI / PCI: fix acpi_pci_irq_enable() memory leak

BugLink: https://bugs.launchpad.net/bugs/1848046
[ Upstream commit 29b49958cf73b439b17fa29e9a25210809a6c01c ]

In acpi_pci_irq_enable(), 'entry' is allocated by kzalloc() in
acpi_pci_irq_check_entry() (invoked from acpi_pci_irq_lookup()). However,
it is not deallocated if acpi_pci_irq_valid() returns false, leading to a
memory leak. To fix this issue, free 'entry' before returning 0.

Fixes: e237a5518425 ("x86/ACPI/PCI: Recognize that Interrupt Line 255 means "not connected"")
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/acpi/pci_irq.c