]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
platform/x86: thinkpad_acpi: Fix profile modes on Intel platforms
authorMark Pearson <mpearson-lenovo@squebb.ca>
Tue, 24 Jan 2023 15:36:23 +0000 (10:36 -0500)
committerHans de Goede <hdegoede@redhat.com>
Wed, 25 Jan 2023 11:45:16 +0000 (12:45 +0100)
commit1bc5d819f0b9784043ea08570e1b21107aa35739
tree71e951760dadde1b79db77a2c1d3e105e9b3c630
parentb0935f110cff5d70da05c5cb1670bee0b07b631c
platform/x86: thinkpad_acpi: Fix profile modes on Intel platforms

My last commit to fix profile mode displays on AMD platforms caused
an issue on Intel platforms - sorry!

In it I was reading the current functional mode (MMC, PSC, AMT) from
the BIOS but didn't account for the fact that on some of our Intel
platforms I use a different API which returns just the profile and not
the functional mode.

This commit fixes it so that on Intel platforms it knows the functional
mode is always MMC.

I also fixed a potential problem that a platform may try to set the mode
for both MMC and PSC - which was incorrect.

Tested on X1 Carbon 9 (Intel) and Z13 (AMD).

Link: https://bugzilla.kernel.org/show_bug.cgi?id=216963
Fixes: fde5f74ccfc7 ("platform/x86: thinkpad_acpi: Fix profile mode display in AMT mode")
Cc: stable@vger.kernel.org
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Link: https://lore.kernel.org/r/20230124153623.145188-1-mpearson-lenovo@squebb.ca
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/thinkpad_acpi.c