]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ALSA: firewire: fix a memory leak bug
authorWenwen Wang <wenwen@cs.uga.edu>
Thu, 8 Aug 2019 05:50:58 +0000 (00:50 -0500)
committerTakashi Iwai <tiwai@suse.de>
Thu, 8 Aug 2019 09:12:26 +0000 (11:12 +0200)
commit1be3c1fae6c1e1f5bb982b255d2034034454527a
tree6804594da24bb8a8aa3ffe48362da900d45e8bdb
parentc7cd7c748a3250ca33509f9235efab9c803aca09
ALSA: firewire: fix a memory leak bug

In iso_packets_buffer_init(), 'b->packets' is allocated through
kmalloc_array(). Then, the aligned packet size is checked. If it is
larger than PAGE_SIZE, -EINVAL will be returned to indicate the error.
However, the allocated 'b->packets' is not deallocated on this path,
leading to a memory leak.

To fix the above issue, free 'b->packets' before returning the error code.

Fixes: 31ef9134eb52 ("ALSA: add LaCie FireWire Speakers/Griffin FireWave Surround driver")
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: <stable@vger.kernel.org> # v2.6.39+
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/packets-buffer.c