]> git.proxmox.com Git - mirror_qemu.git/commit
softfloat: Fix exception flag handling for float32_to_float16()
authorPeter Maydell <peter.maydell@linaro.org>
Mon, 6 Jan 2014 11:47:21 +0000 (11:47 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Tue, 7 Jan 2014 19:18:07 +0000 (19:18 +0000)
commit1bf6beec8a012cae4bb6fbc89c465127e9650c92
treee3a514353a37001c81d2b7c4498f67886d3dff4d
parente3d8cc0536699b66f58b0e3a13a70ee007f61647
softfloat: Fix exception flag handling for float32_to_float16()

Our float32 to float16 conversion routine was generating the correct
numerical answers, but not always setting the right set of exception
flags. Fix this, mostly by rearranging the code to more closely
resemble RoundAndPackFloat*, and in particular:
 * non-IEEE halfprec always raises Invalid for input NaNs
 * we need to check for the overflow case before underflow
 * we weren't getting the tininess-detected-after-rounding
   case correct (somewhat academic since only ARM uses halfprec
   and it is always tininess-detected-before-rounding)
 * non-IEEE halfprec overflow raises only Invalid, not
   Invalid + Inexact
 * we weren't setting Inexact when we should

Also add some clarifying comments about what the code is doing.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <rth@twiddle.net>
fpu/softfloat.c