]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
net: compare_ether_addr[_64bits]() has no ordering
authorJohannes Berg <johannes.berg@intel.com>
Mon, 7 May 2012 13:39:06 +0000 (15:39 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 7 May 2012 23:21:29 +0000 (19:21 -0400)
commit1c430a727fa512500a422ffe4712166c550ea06a
tree5027e4edc9c66a9e49e0e73ba866f5bb326fadcd
parent6eddcb4c82883451aec3be1240f17793370fa62f
net: compare_ether_addr[_64bits]() has no ordering

Neither compare_ether_addr() nor compare_ether_addr_64bits()
(as it can fall back to the former) have comparison semantics
like memcmp() where the sign of the return value indicates sort
order. We had a bug in the wireless code due to a blind memcmp
replacement because of this.

A cursory look suggests that the wireless bug was the only one
due to this semantic difference.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/etherdevice.h