]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
crypto: cavium/nitrox - Replace GFP_ATOMIC with GFP_KERNEL in crypto_alloc_context()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Mon, 23 Jul 2018 08:14:26 +0000 (16:14 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 3 Aug 2018 10:05:49 +0000 (18:05 +0800)
commit1c96dde100987149f42bd6dd97013f7c421f27c7
tree073e1079bfdb99cc65761e3b7881e63a70f0b9e6
parent43490e8046b5d273eb82710b04290c5997138adc
crypto: cavium/nitrox - Replace GFP_ATOMIC with GFP_KERNEL in crypto_alloc_context()

crypto_alloc_context() is only called by nitrox_skcipher_init(), which is
never called in atomic context.

crypto_alloc_context() calls dma_pool_alloc() with GFP_ATOMIC,
which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.
I also manually check the kernel code before reporting it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/cavium/nitrox/nitrox_lib.c