]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
s390/time: Fix clk type in get_tod_clock
authorNathan Chancellor <natechancellor@gmail.com>
Sat, 8 Feb 2020 14:08:59 +0000 (07:08 -0700)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 20 Feb 2020 14:35:35 +0000 (08:35 -0600)
commit1dac9708688582b1265aa0ce4cda2fffd4d7146b
tree6ab075a41a588564e297f41855217f5982d1512d
parentfccc08ed2b20ae788cdeb10b32ca6958497cd632
s390/time: Fix clk type in get_tod_clock

BugLink: https://bugs.launchpad.net/bugs/1864046
commit 0f8a206df7c920150d2aa45574fba0ab7ff6be4f upstream.

Clang warns:

In file included from ../arch/s390/boot/startup.c:3:
In file included from ../include/linux/elf.h:5:
In file included from ../arch/s390/include/asm/elf.h:132:
In file included from ../include/linux/compat.h:10:
In file included from ../include/linux/time.h:74:
In file included from ../include/linux/time32.h:13:
In file included from ../include/linux/timex.h:65:
../arch/s390/include/asm/timex.h:160:20: warning: passing 'unsigned char
[16]' to parameter of type 'char *' converts between pointers to integer
types with different sign [-Wpointer-sign]
        get_tod_clock_ext(clk);
                          ^~~
../arch/s390/include/asm/timex.h:149:44: note: passing argument to
parameter 'clk' here
static inline void get_tod_clock_ext(char *clk)
                                           ^

Change clk's type to just be char so that it matches what happens in
get_tod_clock_ext.

Fixes: 57b28f66316d ("[S390] s390_hypfs: Add new attributes")
Link: https://github.com/ClangBuiltLinux/linux/issues/861
Link: http://lkml.kernel.org/r/20200208140858.47970-1-natechancellor@gmail.com
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 115402ee80cef6560be9d3456b4e61eab0afcf52)
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
arch/s390/include/asm/timex.h