]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
fs/dcache: Fix incorrect nr_dentry_unused accounting in shrink_dcache_sb()
authorWaiman Long <longman@redhat.com>
Wed, 30 Jan 2019 18:52:36 +0000 (13:52 -0500)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 30 Jan 2019 19:02:11 +0000 (11:02 -0800)
commit1dbd449c9943e3145148cc893c2461b72ba6fef0
tree77e131da335779311538ba4f7325190db2ec0ea0
parent1c0490ce902206f4685f812fa81304fd1adf4e35
fs/dcache: Fix incorrect nr_dentry_unused accounting in shrink_dcache_sb()

The nr_dentry_unused per-cpu counter tracks dentries in both the LRU
lists and the shrink lists where the DCACHE_LRU_LIST bit is set.

The shrink_dcache_sb() function moves dentries from the LRU list to a
shrink list and subtracts the dentry count from nr_dentry_unused.  This
is incorrect as the nr_dentry_unused count will also be decremented in
shrink_dentry_list() via d_shrink_del().

To fix this double decrement, the decrement in the shrink_dcache_sb()
function is taken out.

Fixes: 4e717f5c1083 ("list_lru: remove special case function list_lru_dispose_all."
Cc: stable@kernel.org
Signed-off-by: Waiman Long <longman@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/dcache.c