]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
phy: qcom-ufs: Don't kfree devres resource
authorBjorn Andersson <bjorn.andersson@linaro.org>
Sun, 22 Jan 2017 21:17:46 +0000 (13:17 -0800)
committerTim Gardner <tim.gardner@canonical.com>
Wed, 15 Mar 2017 15:32:11 +0000 (10:32 -0500)
commit1dcbcdb90ba082683a06bcc14f468fed9582048c
treeb558c05c765fc88a899ca6d89fa6ce775e9a1e8e
parent9a84078d73ffbe009f394fa06d3a5112d0bf5fe5
phy: qcom-ufs: Don't kfree devres resource

BugLink: http://bugs.launchpad.net/bugs/1673118
commit e7d5e412160c2143de1f818668774b33b3cdab0b upstream.

Upon failing to acquire regulator supplies the qcom-ufs driver calls
kfree() on the devm allocated memory used to store the name of the
regulator, leading to devres corruption.

Rather than switching to using the appropriate free function the patch
acknowledge the fact that "name" is always a constant string and we
don't actually need to create a local copy of it, but rather just
reference the constant string.

Fixes: add78fc05702 ("phy: qcom-ufs: Use devm sibling of kstrdup for regulator names")
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
drivers/phy/phy-qcom-ufs.c