]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ACPI, APEI, HEST Fix the unsuitable usage of platform_data
authorJin Dongming <jin.dongming@np.css.fujitsu.com>
Wed, 29 Sep 2010 11:53:53 +0000 (19:53 +0800)
committerLen Brown <len.brown@intel.com>
Wed, 29 Sep 2010 18:02:26 +0000 (14:02 -0400)
commit1dd6b20e368765223c31569d364219785b24700b
tree1217f73eff83cc603feb86cfd47f4a9876901758
parentbad97c37db9c1ee36de8ac58f9f73931d15a2e94
ACPI, APEI, HEST Fix the unsuitable usage of platform_data

platform_data in hest_parse_ghes() is used for saving the address of entry
information of erst_tab. When the device is failed to be added, platform_data
will be freed by platform_device_put(). But the value saved in platform_data
should not be freed here. If it is done, it will make system panic.

So I think platform_data should save the address of allocated memory
which saves entry information of erst_tab.

This patch fixed it and I confirmed it on x86_64 next-tree.

v2:
    Transport the pointer of hest_hdr to platform_data using
    platform_device_add_data()

Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>
Signed-off-by: Huang Ying <ying.huang@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/acpi/apei/ghes.c
drivers/acpi/apei/hest.c