]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
gianfar: Fix Rx BSY error handling
authorClaudiu Manoil <claudiu.manoil@freescale.com>
Fri, 23 Oct 2015 08:42:00 +0000 (11:42 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 26 Oct 2015 01:28:15 +0000 (18:28 -0700)
commit1de65a5ea32de7b335ab505366d45cefadbbdf71
treea0a5dcfe21acfb75abfe3b3d1c2ceb6fdd142bf3
parent15bf176db1fb00333af7050c0c699fc7b4e4a960
gianfar: Fix Rx BSY error handling

The Rx BSY error interrupt indicates that a frame was
received and discarded due to lack of buffers, so it's
a rx ring overflow condition and has nothing to do with
with bad rx packets.  Use the right counter.

BSY conditions happen when the SoC is under performance
stress.  Doing *more* work in stress situations by trying
to schedule NAPI is not a good idea as the stressed system
becomes still more stressed.  The Rx interrupt is already
at work making sure the NAPI is scheduled.
So calling gfar_receive() here does not help.  This issue
was present since day 1.

Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/gianfar.c