]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
ALSA: hda/ca0132 - Fix possible workqueue stall
authorTakashi Iwai <tiwai@suse.de>
Tue, 5 Nov 2019 13:43:16 +0000 (14:43 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 4 Dec 2019 09:29:26 +0000 (10:29 +0100)
commit1e660f4f6bc049a617ccd0d087c96ea932eb49bc
tree9cd57e1805b94a7ea74919dadc8e0099d8ca3c74
parentd8b2820745d2c57e8d1d03f8426144d1ad61406a
ALSA: hda/ca0132 - Fix possible workqueue stall

BugLink: https://bugs.launchpad.net/bugs/1852338
commit 15c2b3cc09a31620914955cb2a89c277c18ee999 upstream.

The unsolicited event handler for the headphone jack on CA0132 codec
driver tries to reschedule the another delayed work with
cancel_delayed_work_sync().  It's no good idea, unfortunately,
especially after we changed the work queue to the standard global
one; this may lead to a stall because both works are using the same
global queue.

Fix it by dropping the _sync but does call cancel_delayed_work()
instead.

Fixes: 993884f6a26c ("ALSA: hda/ca0132 - Delay HP amp turnon.")
BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1155836
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20191105134316.19294-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Connor Kuehl <connor.kuehl@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
sound/pci/hda/patch_ca0132.c