]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
gpio: pl061: Move irq_chip definition inside struct pl061
authorManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Wed, 24 Oct 2018 17:29:15 +0000 (22:59 +0530)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commit20286b1a9aa35134e2fdd20ab6a6ebdd2935b286
treef8a372b368713004ca8537f9e21e6ad3e685ca2b
parentf843abe045d0e88cb58443f2957ba4ab46e7decc
gpio: pl061: Move irq_chip definition inside struct pl061

BugLink: https://bugs.launchpad.net/bugs/1837477
[ Upstream commit ed8dce4c6f726b7f3c6bf40859b92a9e32f189c1 ]

Keeping the irq_chip definition static will make it shared with multiple
giochips in the system. This practice is considered to be bad and now we
will get the below warning from gpiolib core:

"detected irqchip that is shared with multiple gpiochips: please fix the
driver."

Hence, move the irq_chip definition from static to `struct pl061` for
using a unique irq_chip for each gpiochip.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/gpio/gpio-pl061.c