]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
perf probe: Fix --line option behavior
authorNamhyung Kim <namhyung@kernel.org>
Tue, 1 Apr 2014 04:47:57 +0000 (13:47 +0900)
committerJiri Olsa <jolsa@redhat.com>
Mon, 14 Apr 2014 10:55:39 +0000 (12:55 +0200)
commit202c7c123c96a1c193149b7fa2718d7fb143efb2
treecb851ce23ae95871a5f3601f80cf1bd67cae7dfe
parent2c529e4e6aab405aa52e8627cbd691ed28b56a0b
perf probe: Fix --line option behavior

The commit 5a62257a3ddd1 ("perf probe: Replace line_list with
intlist") replaced line_list to intlist but it has a problem that if a
same line was added again, it'd return -EEXIST rather than 1.

Since line_range_walk_cb() only checks the result being negative, it
resulted in failure or segfault sometimes.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Link: http://lkml.kernel.org/r/1396327677-3657-1-git-send-email-namhyung@kernel.org
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
tools/perf/util/probe-finder.c