]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
tg3: Fix advertisement handling
authorHiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Tue, 22 Nov 2011 04:05:41 +0000 (04:05 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 22 Nov 2011 20:19:07 +0000 (15:19 -0500)
commit202ff1c26c768efeead20b388556eda265dc8352
tree6e05f54791196f9320ee6715667fc2bf8bd3ba53
parent570e57bcbcc4df5581b1e9c806ab2b16e96ea7d3
tg3: Fix advertisement handling

Commit 28011cf19b (net: Add ethtool to mii advertisment conversion
helpers) added a helper function ethtool_adv_to_mii_100bt() and
tg3_copper_is_advertising_all(), tg3_phy_autoneg_cfg() were
modified to use this.
Before that commit, ethtool to mii advertisement conversion was
done wrt speed, but now pause operation is also taken account.
So, in tg3_copper_is_advertising_all(), below condition becomes
true and this makes link up fails.

if ((adv_reg & ADVERTISE_ALL) != all_mask)
return 0;

To fix this add ADVERTISE_ALL bit and operation to cap speed,
and change default advertisement not including ADVERTISED_Pause.

Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/tg3.c