]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ppp: defer netns reference release for ppp channel
authorWANG Cong <xiyou.wangcong@gmail.com>
Wed, 6 Jul 2016 05:12:36 +0000 (22:12 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 9 Jul 2016 03:46:37 +0000 (23:46 -0400)
commit205e1e255c479f3fd77446415706463b282f94e4
tree98e80b94c077894fb29591ba610da272349549cd
parent06708f81528725148473c0869d6af5f809c6824b
ppp: defer netns reference release for ppp channel

Matt reported that we have a NULL pointer dereference
in ppp_pernet() from ppp_connect_channel(),
i.e. pch->chan_net is NULL.

This is due to that a parallel ppp_unregister_channel()
could happen while we are in ppp_connect_channel(), during
which pch->chan_net set to NULL. Since we need a reference
to net per channel, it makes sense to sync the refcnt
with the life time of the channel, therefore we should
release this reference when we destroy it.

Fixes: 1f461dcdd296 ("ppp: take reference on channels netns")
Reported-by: Matt Bennett <Matt.Bennett@alliedtelesis.co.nz>
Cc: Paul Mackerras <paulus@samba.org>
Cc: linux-ppp@vger.kernel.org
Cc: Guillaume Nault <g.nault@alphalink.fr>
Cc: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Reviewed-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ppp/ppp_generic.c