]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
crypto: x86/morus - fix handling chunked inputs and MAY_SLEEP
authorEric Biggers <ebiggers@google.com>
Fri, 1 Feb 2019 07:51:39 +0000 (23:51 -0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 8 Feb 2019 07:30:08 +0000 (15:30 +0800)
commit2060e284e9595fc3baed6e035903c05b93266555
tree684f2477a73cb2966574a1aecf5fe474be9816b8
parentba6771c0a0bc2fac9d6a8759bab8493bd1cffe3b
crypto: x86/morus - fix handling chunked inputs and MAY_SLEEP

The x86 MORUS implementations all fail the improved AEAD tests because
they produce the wrong result with some data layouts.  The issue is that
they assume that if the skcipher_walk API gives 'nbytes' not aligned to
the walksize (a.k.a. walk.stride), then it is the end of the data.  In
fact, this can happen before the end.

Also, when the CRYPTO_TFM_REQ_MAY_SLEEP flag is given, they can
incorrectly sleep in the skcipher_walk_*() functions while preemption
has been disabled by kernel_fpu_begin().

Fix these bugs.

Fixes: 56e8e57fc3a7 ("crypto: morus - Add common SIMD glue code for MORUS")
Cc: <stable@vger.kernel.org> # v4.18+
Cc: Ondrej Mosnacek <omosnace@redhat.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Ondrej Mosnacek <omosnace@redhat.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
arch/x86/crypto/morus1280_glue.c
arch/x86/crypto/morus640_glue.c