]> git.proxmox.com Git - mirror_qemu.git/commit
scripts/device-crash-test: Use a QMP timeout
authorJohn Snow <jsnow@redhat.com>
Thu, 18 Nov 2021 20:46:19 +0000 (15:46 -0500)
committerJohn Snow <jsnow@redhat.com>
Mon, 22 Nov 2021 23:41:21 +0000 (18:41 -0500)
commit206439cd8937a3dc556537074d5d37e5d74eb0d0
tree683814868f15dd7d29f89c7853d9e71d3a8694da
parent1611e6cf4e7163f6102b37010a8b7e7120f468b5
scripts/device-crash-test: Use a QMP timeout

Despite all the previous fixes, it's still possible for
device-crash-test to wedge itself in the case that QEMU terminates *so
quickly* that it doesn't even begin a connection attempt to our QMP
client. Python will just joyfully wait ad infinitum for a connection
that will now never arrive.

The real fix is to use asyncio to simultaneously poll both the health of
the launched process AND the connection attempt. That's quite a bit more
invasive than just setting a connection timeout, though.

Do the very simplest thing for now.

Signed-off-by: John Snow <jsnow@redhat.com>
Message-id: 20211118204620.1897674-7-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
scripts/device-crash-test