]> git.proxmox.com Git - mirror_qemu.git/commit
block/qapi: reduce the coupling between the bdrv_query_stats and bdrv_query_bds_stats
authorDou Liyang <douly.fnst@cn.fujitsu.com>
Sun, 15 Jan 2017 08:01:14 +0000 (16:01 +0800)
committerMax Reitz <mreitz@redhat.com>
Sat, 11 Feb 2017 23:47:42 +0000 (00:47 +0100)
commit20a6d768f5c1a590d8a42c343aa862f89966cb23
treed56227993712cb4b726fc3b06d462876c20e743f
parent256e3b6387c91113a39cdfaa5d3b020ccd4b1a33
block/qapi: reduce the coupling between the bdrv_query_stats and bdrv_query_bds_stats

The bdrv_query_stats and bdrv_query_bds_stats functions need to call
each other, that increases the coupling. it also makes the program
complicated and makes some unnecessary tests.

Remove the call from bdrv_query_bds_stats to bdrv_query_stats, just
take some recursion to make it clearly.

Avoid testing whether the blk is NULL during querying the bds stats.
It is unnecessary.

Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
Message-id: 1484467275-27919-2-git-send-email-douly.fnst@cn.fujitsu.com
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
block/qapi.c