]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
radeon: avoid double free in ci_dpm_init()
authorNikita Zhandarovich <n.zhandarovich@fintech.ru>
Thu, 13 Apr 2023 15:12:28 +0000 (08:12 -0700)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 18 Apr 2023 20:28:54 +0000 (16:28 -0400)
commit20c3dffdccbd494e0dd631d1660aeecbff6775f2
tree73d5d315ad7ceaead3e74a6b60e9b3c8b715a6d5
parent94344e62a9ce8abcf681390f9822a7b075cf98e2
radeon: avoid double free in ci_dpm_init()

Several calls to ci_dpm_fini() will attempt to free resources that
either have been freed before or haven't been allocated yet. This
may lead to undefined or dangerous behaviour.

For instance, if r600_parse_extended_power_table() fails, it might
call r600_free_extended_power_table() as will ci_dpm_fini() later
during error handling.

Fix this by only freeing pointers to objects previously allocated.

Found by Linux Verification Center (linuxtesting.org) with static
analysis tool SVACE.

Fixes: cc8dbbb4f62a ("drm/radeon: add dpm support for CI dGPUs (v2)")
Co-developed-by: Natalia Petrova <n.petrova@fintech.ru>
Signed-off-by: Nikita Zhandarovich <n.zhandarovich@fintech.ru>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/radeon/ci_dpm.c